Minimum Sell Amounts #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarinkovic
reviewed
Dec 4, 2023
src/facets/AdminFacet.sol
Outdated
Comment on lines
110
to
112
| function objectMinimumSell(bytes32 _objectId) external view returns (uint256) { | ||
| return LibAdmin._objectMinimumSell(_objectId); | ||
| } |
There was a problem hiding this comment.
Why not make this a getMinimumSell in the MarketFacet, setter is already there?
There was a problem hiding this comment.
I was thinking we could make the getters the same name as the variable, and drop the get prefix, but for consistency with the rest of the codebase we could add the get prefix. I'll move everything to Market.
src/libs/LibAdmin.sol
Outdated
Comment on lines
180
to
183
| function _objectMinimumSell(bytes32 _objectId) internal view returns (uint256) { | ||
| AppStorage storage s = LibAppStorage.diamondStorage(); | ||
| return s.objectMinimumSell[_objectId]; | ||
| } |
There was a problem hiding this comment.
Maybe it makes more sense to put this into LibMarket?
amarinkovic
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement minimum sell amounts allowed on the marketplace to prevent griefing with really small order amounts.
Mentioned in Immunify 24703.