Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usize with u64 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexanderkjall
Copy link

as usize is 32-bit on 32-bit architectures.

Currently the project doesn't build on any 32-bit architecture: https://buildd.debian.org/status/package.php?p=rust-compound-duration

With problems like this:

warning: this arithmetic operation will overflow
   --> src/lib.rs:169:26
    |
169 |     let mut ns = nanos % (DAY * NANOS);
    |                          ^^^^^^^^^^^^^ attempt to compute `86400_usize * 1000000000_usize`, which would overflow
    |
    = note: `#[warn(arithmetic_overflow)]` on by default

It looks to me like this breaks your public api, so I also bumped the major version to 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant