DefaultProps is deprecated - remove from code. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbudin
approved these changes
Jan 21, 2024
|
This is now released in version 8.1.1. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
While using this great package I've seen some warnings in the console suggests that
defaultPropsare deprecated.I've searched in react repo and it seems it's been there a while - facebook/react#25699
I've found this resource that elaborates more - https://sophiabits.com/blog/stop-using-defaultprops
Bottom line, I've looked in the code and it seems that the
defaultPropshere where all null, my idea was just to delete them.Hope you'll find it helpful 🙏