Fixed fable-compiler#3658

ncave · Jun 13, 2024 · cbd79c8 · cbd79c8
1 parent 0913c0c
commit cbd79c8
Showing 1 changed file with 22 additions and 6 deletions.
diff --git a/src/Fable.Transforms/FSharp2Fable.fs b/src/Fable.Transforms/FSharp2Fable.fs
@@ -1474,20 +1474,33 @@ let private transformExpr (com: IFableCompiler) (ctx: Context) appliedGenArgs fs
                 |> addErrorAndReturnNull com ctx.InlinePath (makeRangeFrom fsExpr)
     }
 
-let private isIgnoredNonAttachedMember (meth: FSharpMemberOrFunctionOrValue) =
-    Option.isSome meth.LiteralValue
-    || meth.Attributes
+let private isIgnoredNonAttachedMember (memb: FSharpMemberOrFunctionOrValue) =
+    Option.isSome memb.LiteralValue
+    || memb.Attributes
        |> Seq.exists (fun att ->
            match att.AttributeType.TryFullName with
            | Some(Atts.global_ | Naming.StartsWith Atts.import _ | Naming.StartsWith Atts.emit _) -> true
            | _ -> false
        )
     || (
-        match meth.DeclaringEntity with
+        match memb.DeclaringEntity with
         | Some ent -> isGlobalOrImportedFSharpEntity ent
         | None -> false
     )
 
+let private isErasedUnionCaseTester (memb: FSharpMemberOrFunctionOrValue) =
+    // if memb.IsUnionCaseTester then // TODO: this currently fails, use when fixed
+    if memb.IsPropertyGetterMethod && memb.LogicalName.StartsWith("get_Is") then
+        // currently returns true for any tester if any union case is erased
+        // TODO: return true only when the tester's own union case is erased
+        match memb.DeclaringEntity with
+        | Some ent when ent.IsFSharpUnion ->
+            ent.UnionCases
+            |> Seq.exists (fun unionCase -> hasAttrib Atts.erase unionCase.Attributes)
+        | _ -> false
+    else
+        false
+
 let private isCompilerGenerated (memb: FSharpMemberOrFunctionOrValue) (args: FSharpMemberOrFunctionOrValue list list) =
     memb.IsCompilerGenerated
     && memb.IsInstanceMember
@@ -1905,6 +1918,9 @@ let private transformMemberDecl
         []
     elif memb.IsImplicitConstructor then
         transformPrimaryConstructor com ctx memb args body
+    // Ignore union case testers for unions with erased union cases
+    elif isErasedUnionCaseTester memb then
+        []
     // Ignore members generated by the F# compiler (for comparison and equality)
     elif isCompilerGenerated memb args then
         []
@@ -2047,8 +2063,8 @@ let rec private transformDeclarations (com: FableCompiler) ctx fsDecls =
                         }
                 ]
             | sub -> transformDeclarations com ctx sub
-        | FSharpImplementationFileDeclaration.MemberOrFunctionOrValue(meth, args, body) ->
-            transformMemberDecl com ctx meth args body
+        | FSharpImplementationFileDeclaration.MemberOrFunctionOrValue(memb, args, body) ->
+            transformMemberDecl com ctx memb args body
         | FSharpImplementationFileDeclaration.InitAction fe ->
             let ctx = { ctx with UsedNamesInDeclarationScope = HashSet() }
             let e = transformExpr com ctx [] fe |> run