fix:Multilingual preflabels #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
========================================
Coverage 73.34% 73.34%
========================================
Files 53 53
Lines 2953 2953
========================================
Hits 2166 2166
Misses 787 787
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -208,7 +208,7 @@ def test_roots_for_cls | |||
| roots = MultiJson.load(last_response.body) | |||
| assert_equal 9, roots.length | |||
| roots.each do |r| | |||
| assert_instance_of String, r["prefLabel"] | |||
| assert_instance_of String, r["prefLabel"], r["@id"] | |||
There was a problem hiding this comment.
when this assertion fails (for example if prefLabel = nil), it's informative to know the ID of the term that caused this failure
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: ncbo/ontologies_linked_data#220