Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Enhance locationiq - formattedAddress, county, unify country name #335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

⚡️ Enhance locationiq - formattedAddress, county, unify country name #335

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75812e9
✨ add formattedAddress and county to locationiq + unify country name
a-tokyo Mar 10, 2022
d921367
Update lib/geocoder/locationiqgeocoder.js
a-tokyo Apr 10, 2022
3ccae4b
Update locationiqgeocoder.js
a-tokyo Apr 10, 2022
d96a3f9
Remove hardcoded country
a-tokyo Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions lib/geocoder/locationiqgeocoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,25 +120,32 @@ LocationIQGeocoder.prototype._reverse = function(query, callback) {
LocationIQGeocoder.prototype._formatResult = function(result) {
// transform lat and lon to real floats
var transformedResult = {
'latitude' : result.lat ? parseFloat(result.lat) : undefined,
'longitude' : result.lon ? parseFloat(result.lon) : undefined
latitude : result.lat ? parseFloat(result.lat) : undefined,
longitude : result.lon ? parseFloat(result.lon) : undefined,
};

if (result.display_name) {
transformedResult.formattedAddress = result.display_name;
}

if (result.address) {
transformedResult.country = result.address.country;
transformedResult.country = result.address.country;
/* make sure country name is unified accross geocoders */
transformedResult.country = result.address.country === 'United States of America' ? 'United States' : result.address.country;
a-tokyo marked this conversation as resolved.
Show resolved Hide resolved
transformedResult.city = result.address.city || result.address.town || result.address.village || result.address.hamlet;
transformedResult.state = result.address.state;
transformedResult.zipcode = result.address.postcode;
transformedResult.streetName = result.address.road || result.address.cycleway;
transformedResult.streetNumber = result.address.house_number;

if (transformedResult.county) {
transformedResult.county = result.address.county;
}
a-tokyo marked this conversation as resolved.
Show resolved Hide resolved

// make sure countrycode is always uppercase to keep node-geocoder api formats
var countryCode = result.address.country_code;
if (countryCode) {
countryCode = countryCode.toUpperCase();
}

transformedResult.countryCode = countryCode;
}
return transformedResult;
Expand Down