Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating CDS template #409

Merged
merged 18 commits into from
Jun 3, 2024
Merged

Generating CDS template #409

merged 18 commits into from
Jun 3, 2024

Conversation

aditigopalan
Copy link
Contributor

Fixes #396

Copy link
Contributor

@adamjtaylor adamjtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Lets move this into HTAN.model.csv and then build out the attributes that are missing with valid values and validation rules

@aclayton555
Copy link
Contributor

Need to add this as a component, "CDS Sequencing"

Copy link
Contributor

@adamjtaylor adamjtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Some minor bits to take care off in the attributes. And I think we still need to add the top level component line

See errors in the 'check attributes are used test'

https://github.com/ncihtan/data-models/actions/runs/9352261937/job/25739971229

HTAN.model.csv Outdated Show resolved Hide resolved
HTAN.model.csv Outdated Show resolved Hide resolved
HTAN.model.csv Outdated Show resolved Hide resolved
cds-template.csv Outdated Show resolved Hide resolved
Copy link
Contributor

@adamjtaylor adamjtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once we merge can you try and generate a template with schematic or staging DCA and check that the google sheets template looks sensible and the dependency behaviour seems captured.

@adamjtaylor adamjtaylor merged commit ed266a3 into main Jun 3, 2024
@adamjtaylor adamjtaylor deleted the cds-template branch June 3, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop and implement HTAN/CDS seq template
3 participants