-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating CDS template #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Lets move this into HTAN.model.csv
and then build out the attributes that are missing with valid values and validation rules
Need to add this as a component, "CDS Sequencing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Some minor bits to take care off in the attributes. And I think we still need to add the top level component line
See errors in the 'check attributes are used test'
https://github.com/ncihtan/data-models/actions/runs/9352261937/job/25739971229
…into cds-template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Once we merge can you try and generate a template with schematic or staging DCA and check that the google sheets template looks sensible and the dependency behaviour seems captured.
Fixes #396