Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ncoghlan committed Oct 23, 2024
1 parent 91e0858 commit fce9ff2
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions peps/pep-0396.rst
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,17 @@ has changed significantly in the intervening years since this PEP was
first written, and APIs such as ``importlib.metadata.version()`` [11]_
provide for a much better experience.

This rejection was subsequently reclassified as a withdrawal,
This rejection was reclassified as a withdrawal on 2024-10-21,
as the previous state was being misinterpreted [12]_ as suggesting
that *no* modules should be defining ``__version__`` attributes,
which definitely isn't the case.

Modules may still define ``__version__`` if they choose to,
but choosing *not* to do so won't interfere with looking up
the version information for installed distribution packages.
Modules are still free to define ``__version__`` if they choose to.
However, choosing *not* to do so won't interfere with looking up
the version information for installed distribution packages, so an
Informational PEP isn't the right tool to document community
conventions around the use of module ``__version__`` attributes
(they're better covered as part of the Python Packaging User Guide).


User Stories
Expand Down

0 comments on commit fce9ff2

Please sign in to comment.