Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to rule and crisp expression parsing #7

Merged
merged 16 commits into from
Jul 19, 2024
Merged

Conversation

brownag
Copy link
Member

@brownag brownag commented Jul 19, 2024

This ensures that all primary, ready-to-use rules can be parsed.

  • Updates rules, evaluations, properties datasets to include dataafuse field (ready-to-use flag)
  • Adds support for IsNull curve type
  • Many improvements for syntax edge cases in crisp expressions

This update has been tested on all current primary rules that are marked ready to use. There may still be some cases that need to be tested for parity with NASIS, especially for use of wildcards in equality, MATCHES, IMATCHES but there all conversions of crisp expression to R function should now at least result in valid R syntax.

@brownag brownag merged commit 5c1ff31 into master Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant