Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge shakeLintIgnore for autodeps #817

Closed
wants to merge 1 commit into from

Conversation

jacereda
Copy link
Contributor

Looks like AutoDeps isn't taking shakeLintIgnore into account.

@jacereda
Copy link
Contributor Author

I'm not even sure I need this, this was a workaround for the fact that the Visual C linker seems to use the equivalent of writeFileChanged for the IMPLIB: output file (the .lib when creating a DLL). Looks like fsatrace will detect that .lib file as a write (when first created or when you change the exported symbols) or as a read (when nothing changed regarding symbols).

I was getting recursive rules that I suspect have to do with that. I'll try to figure out if there's something better on my side (like switching to &%> to use the --share) that doesn't require shakeLintIgnore.

@jacereda
Copy link
Contributor Author

I guess this could be left as is in favour of a fix for #818

@jacereda jacereda closed this Jan 13, 2022
@ndmitchell
Copy link
Owner

Agreed, I think #818 is the right solution here. Broadly speaking I'm not sure linting and auto deps should share settings - they are based on the same underlying mechanism, but are used for quite different purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants