Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent component cache #387

Merged
merged 11 commits into from
Apr 3, 2024
Merged

Conversation

pavelisnear
Copy link
Contributor

This PR is built on top of the previously reverted #288

Introduces a a persistent component cache:
image

Test example component (compatibility with the block height feature)

import BlockHeightWithFlagTest from 'near://pavel-pagoda.near/BlockHeightWithFlagTest@115592558';
import BlockHeightWithFlagTestLatest from 'near://pavel-pagoda.near/BlockHeightWithFlagTest';

export default function () {
  return (
    <div>
      <h1>Sandbox with a block height:</h1>
      <BlockHeightWithFlagTest />
      <hr />
      <h1>Sandbox latest:</h1>
      <BlockHeightWithFlagTestLatest />
    </div>
  );
}

Fixes #303

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bos-web-engine ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 8:11am
bos-web-engine-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 8:11am
bos-web-engine-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 8:11am

Copy link
Contributor

@andy-haynes andy-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some questions and suggestions but nothing major.

packages/compiler/src/cache.ts Outdated Show resolved Hide resolved
packages/application/src/hooks/useCompiler.ts Outdated Show resolved Hide resolved
packages/compiler/src/cache.ts Outdated Show resolved Hide resolved
packages/compiler/src/cache.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/compiler.ts Outdated Show resolved Hide resolved
packages/compiler/src/compiler.ts Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andy-haynes andy-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I added notes on a couple minor things I noticed, take a look when you rebase and we'll get this out 🎉

packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
packages/compiler/src/source.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andy-haynes andy-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work ❤️

@pavelisnear pavelisnear merged commit 9950331 into main Apr 3, 2024
6 checks passed
@pavelisnear pavelisnear deleted the feat/persistent-cache-latest branch April 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some CSS rules are lost on subsequent loads
2 participants