-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Preact versioning #393
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
While this does fix the issue in #323, it requires specifying version 10.20.1 which does not play nice with |
Phosphor icons do not appear to work on this branch even with the full path specifier. Is that expected? |
It's broken in production since However there's a bug with specifying a version with subpaths, i.e. it should be specified as I'll create an issue for the subpath versioning and fix the Component in that PR. |
This PR updates the way Preact dependencies are imported and specified for third-party packages. In particular:
stable/
builds to ensure the same instance is used within the imported packageexternal
to ensure only one instance of Preact is usedpreact/compat
import paths have been updated to include thebuild hash (subpaths required when markingX-YS9yZWFjdDpwcmVhY3QvY29tcGF0
) that appears to always be imported byesm.sh
bundles whenreact
is swapped out forpreact/compat
preact
as an external dependencyThis fixes #323 and unblocks progress on importing other libraries (tested with
@chakra-ui
so far), though the latter still needs some work.