Read URL Query Params MVP #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mpeterdev
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #334
Please check out this comment for more context on the implementation in this PR: #334 (comment)
The implementation itself is pretty simple and should be easy to refactor if any of us have concerns down the road. Here's an example component you can check out: https://bos-web-engine-git-feat-read-url-f462bd-near-developer-console.vercel.app/near/RocTest?foobar=abc
I made sure this implementation will support Next's
<Link>component (client side routing) if/when we start using that inside our RoC components. The query parameters update and the root component receives the updated props.Viewing the gateway:
Viewing the sandbox: