Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --nonce and --block-hash arguments to allow signing transactions in offline #202

Closed
frol opened this issue May 24, 2023 · 0 comments · Fixed by #209
Closed

Respect --nonce and --block-hash arguments to allow signing transactions in offline #202

frol opened this issue May 24, 2023 · 0 comments · Fixed by #209
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@frol
Copy link
Collaborator

frol commented May 24, 2023

Currently, --nonce and --block-hash CLI arguments seem to be ignored in all the signing options.

pub nonce: Option<u64>,
#[interactive_clap(long)]
#[interactive_clap(skip_default_input_arg)]
pub block_hash: Option<String>,

let current_nonce = rpc_query_response
.access_key_view()
.wrap_err("Error current_nonce")?
.nonce;

near-cli-rs should not make any calls to RPC when nonce and block-hash is specified, so it will work on computers that are not connected to the Internet.

@frol frol added the bug Something isn't working label May 24, 2023
@frol frol assigned FroVolod and unassigned FroVolod May 24, 2023
@frol frol added the good first issue Good for newcomers label May 24, 2023
@frol frol mentioned this issue Jun 4, 2023
@frol frol closed this as completed in #209 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants