Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign offline #209

Merged
merged 52 commits into from
Jun 5, 2023
Merged

Sign offline #209

merged 52 commits into from
Jun 5, 2023

Conversation

FroVolod
Copy link
Collaborator

@FroVolod FroVolod commented May 31, 2023 •
edited by frol
Loading

Resolves #201
Resolves #202

FroVolod and others added 25 commits May 30, 2023 15:57
start (draft)
8b54398
start (draft)
e583830
Merge branch 'sign-offline' of https://github.com/near/near-cli-rs in…
2eadc03 
…to sign-offline
draft
5378180
fixed GlobalContext
47a4e83
draft
3df29dc
added offline mode for tokens commands
97bea23
added offline mode for sign_with...
006a47b
added offline mode for sign_with..keychain (draft)
4fc49ba
added offline mode for network... (draft)
7369c2b
added offline mode for sign-with-keychain
4a5aac1
fixed
c979e2a
added SignLater
dab0ac0
draft (Account)
b078139
fixed
57d3476
added offline mode for creating account
bff5d00
clippy
789d0c3
refactored
3c81e66
fmt
13ad4cd
added offline mode for DeleteAccount
90745f7
@FroVolod
Merge branch 'master' into sign-offline
5c4869e
fixed
7245c50
added offline mode for AddKey
44daac9
added offline mode for DeleteKey
88b8b0e
added offline mode for ManageStorageDeposit
90dc245
frol
frol requested changes Jun 2, 2023
View reviewed changes
src/transaction_signature_options/sign_with_private_key/mod.rs Outdated Show resolved Hide resolved
src/transaction_signature_options/sign_with_private_key/mod.rs Outdated Show resolved Hide resolved
src/types/mod.rs Outdated Show resolved Hide resolved
src/transaction_signature_options/sign_with_keychain/mod.rs Outdated Show resolved Hide resolved
@FroVolod FroVolod marked this pull request as ready for review June 4, 2023 13:33
frol
frol requested changes Jun 4, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, address the clippy warning in src/network/mod.rs

src/commands/account/delete_account/mod.rs Outdated Show resolved Hide resolved
src/commands/account/delete_account/mod.rs Outdated Show resolved Hide resolved
src/commands/account/storage_management/mod.rs Outdated Show resolved Hide resolved
src/commands/transaction/construct_transaction/add_action_1/add_action/delete_account/mod.rs Outdated Show resolved Hide resolved
src/commands/transaction/send_meta_transaction/sign_as/mod.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/transaction_signature_options/mod.rs Outdated Show resolved Hide resolved
@FroVolod FroVolod marked this pull request as draft June 5, 2023 06:49
@FroVolod FroVolod marked this pull request as ready for review June 5, 2023 11:15
@frol frol merged commit 834f7a3 into master Jun 5, 2023
@frol frol deleted the sign-offline branch June 5, 2023 12:43
@frol frol mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@FroVolod @frol