Improve commands - order networks selection based on the selected account id #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaodt
changed the title
|
hi @frol , could you please help me review this PR? |
frol
requested changes
Jul 15, 2023
src/common.rs
Outdated
| pub fn input_network_name( | ||
| config: &crate::config::Config, | ||
| account_id: Option<crate::types::account_id::AccountId>, |
There was a problem hiding this comment.
I don't see a reason to pass account_id by value, so I suggest passing it by reference to avoid unnecessary clones on the caller side:
Suggested change
| account_id: Option<crate::types::account_id::AccountId>, | |
| account_id: Option<&crate::types::account_id::AccountId>, |
src/common.rs
Outdated
Comment on lines
1613
to
1615
| let mut variants = config.network_connection.keys().collect::<Vec<_>>(); | ||
| variants.sort(); | ||
| variants |
There was a problem hiding this comment.
Preserve the configuration order, do not sort.
|
Finished per your review, please recheck. |
…s, and refactored to support a list of accounts
…k-on-selected-accid
frol
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
I realized that leaving the review comments would take longer than finishing it myself, so I refactored the code to always use near_primitives::types::AccountId instead of crate::types::account_id::AccountId in Context structs, and added support for multiple account ids (e.g. sender/receiver/nft_contract_account_id)
Merged
FroVolod
pushed a commit
that referenced
this pull request
Aug 29, 2023
FroVolod
pushed a commit
that referenced
this pull request
Aug 29, 2023
FroVolod
pushed a commit
that referenced
this pull request
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is served for #222.