Add relayer functionality to fastauth #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MaximusHaximus
commented
Apr 28, 2023
•
MaximusHaximus
commented
- Updates recovery service API calls to match advanced account API
- Implements near-social LAK-only functionality for fastauth accounts
- Adds relayer awareness to fastauth implementation
- Bumps NAJ to 2.1.3
- Bumps wallet-selector to latest versions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
itegulov
approved these changes
Apr 28, 2023
| try { | ||
| if ( | ||
| !accountCreationData.limitedAccessKey || | ||
| !accountCreationData.isCreated |
There was a problem hiding this comment.
I might be missing something here, but shouldn't this be:
Suggested change
| !accountCreationData.isCreated | |
| accountCreationData.isCreated |
There was a problem hiding this comment.
This case is a bit counter-intuitive -- after creating the account via recovery service, we redirect to the app after setting a flag indicating that the account was created successfully -- so this is correct, if the account wasn't created we can't yet fire the signIn() logic here
| isRecovery ? "Recovering account..." : "Creating account..." | ||
| ); | ||
|
|
||
| // TODO: Call MPC Service with accountId, publicKey, and oauthToken to create account |
| }; | ||
|
|
||
| await fetch( | ||
| `${MPC_RECOVERY_URL}/${isRecovery ? "add_key" : "new_account"}`, |
There was a problem hiding this comment.
I don't think add_key supports CreateAccountOptions. Do you need us to add it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.