Implement Fallback to User Balance for Transactions When Relayer Fails #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esaminu
reviewed
Jun 4, 2024
esaminu
reviewed
Jun 10, 2024
| @@ -302,30 +322,81 @@ export class FastAuthWalletConnection { | |||
| ); | |||
| newUrl.searchParams.set('success_url', callbackUrl || currentUrl.href); | |||
| newUrl.searchParams.set('failure_url', callbackUrl || currentUrl.href); | |||
There was a problem hiding this comment.
Very nice but with time these params can be removed for simplicity so that we have iframe only logic 👍
There was a problem hiding this comment.
Yeah, let's open a ticket for this clean up! Will be amazing to remove the duplicated logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fallback mechanism for transactions when the relayer service fails to relay them due to specific issues such as actions not being allowed or the sender/receiver not being whitelisted. In such cases, the transaction will be retried using the user's own balance, ensuring that the transaction can still be processed without dependency on the relayer's current state or configuration. This enhancement improves the robustness of transaction handling by providing an alternative path for transaction completion.