-
Notifications
You must be signed in to change notification settings - Fork 627
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[refactor] Extracted near-vm-runner from near-primitives (#11578)
### Description This pull request tries to de-couple the near-vm-runner from the dependency list of near-primitives ### Motivation Near-vm-runner is not a proper dependency for something primitive, but now it's a part of many near dependencies. Also, near-vm-runner uses rustix::fs, a blocker for any release on Windows. * [here](near/near-cli-rs#350) you can see that Windows built is broken. * [here](https://github.com/near/nearcore/compare/1.39.2...akorchyn:nearcore:patch-defaults?expand=1) you can see an example patch so build pass ### How is it done? Well, I have proceeded next way: * Moved ViewApplyState to node-runtime * Copied ProfileV3 to near-primitives and created conversion in node-runtime #### TODO: * [x] Windows CI for public libraries :) * [x] Fix tests compilation ## For reviewers * Please take a look at a patch that I have created [here](https://github.com/near/nearcore/compare/1.39.2...akorchyn:nearcore:patch-defaults?expand=1). Do you think we could rollout 0.22.2 release, so I could continue rolling out 0.22, but go with this more proper implementation for future 0.23/0.24 release?
- Loading branch information
1 parent
1e199de
commit fb4d835
Showing
18 changed files
with
542 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.