-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): rpc query contract code deployed #3714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a sanity test to make sure that it works? Also this query maybe expensive if the contract code is large @frol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a few nits which you may ignore and merge as is, I only want us to be on the same page in terms of the reasoning we apply to the order of enum variants and From
impls.
I expect it to be on par with serving static files over HTTP (like Nginx does), which is usually bound by the network bandwidth rather than by the trie lookup, disk read, or memory read (borsh deserialization). Thus, I don't expect it to be more expensive than |
@evgenykuzyakov can you review to unblock this PR? |
Let's please let @thisisjoshford know when we add new routes/endpoints so we can update the docs :) |
@mikedotexe I even submitted a PR: near/docs#562 😄 |
My man! Thanks, Frol, on top of things as always. I searched for " |
Address #1712,
also, add a dump_code command to state-viewer, so we can dump wasm file given account id, from node that doesn't yet have this rpc, e.g. testnet/mainnet:
Test Plan
and also nightly ci test_upload_contract_testnet