Limited access key support for mintbase wallet #1085
Conversation
|
@kujtimprenkuSQA , can you please check and fix this one. @trechriron , can you pls assist to expedite this. |
There was a problem hiding this comment.
Hi, @vikpande I no longer have access on the repo but I am reviewing it nevertheless.
The support for limited access key works fine.
- One thing I noticed when signing transactions that require confirmation on the wallet I am not being redirected back to the dApp.
Downgrade near-api-js to ^2.1.3 Revert "Downgrade near-api-js to ^2.1.3" This reverts commit f0590fe. Downgraded mintbase wallet to ^2.1.3 Yarn.lock
|
@SurgeCode could you check the failed GH-Actions. |
Was having some problems generating the lock, should be good now @kujtimprenkuSQA 👍 |
|
@SurgeCode unfortunately Do you mind if I create a copy of your PR and close this one (or you can try to fix them on your end)? |
|
@kujtimprenkuSQA @SurgeCode - let's fix the yarn file and and update this branch... |
|
@kujtimprenkuSQA @trechriron tests passed now with lock file from @kujtimprenkuSQA |
|
@trechriron the PR looks good to me feel free to approve and merge. |
Added optional support for limited access keys on mintbase wallet.
If you provide a contractId in setup a limited access key will be generated that can be used through the standardised API otherwise It wont be created which offers smoother onboarding for cases where it isn't necessary
Checklist:
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings