Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage #726

Merged
merged 15 commits into from
Apr 6, 2023
Merged

Test coverage #726

merged 15 commits into from
Apr 6, 2023

Conversation

amirsaran3
Copy link
Collaborator

sender.spec.ts doesn't work. I am not getting any errors so I am not sure how to fix it. I need some help with it.

@kujtimprenkuSQA
Copy link
Collaborator

Add "resolveJsonModule": true to the compilerOotions of the tsconfig.json of the sender package.

Not sure why the .json files are being picked by NX when we run the tests, this should make sender.spec.ts work.

@amirsaran3 amirsaran3 marked this pull request as ready for review March 31, 2023 11:14
@amirsaran3 amirsaran3 merged commit 2192a25 into dev Apr 6, 2023
@amirsaran3 amirsaran3 deleted the test-coverage branch April 6, 2023 07:57
@kujtimprenkuSQA kujtimprenkuSQA mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kujtimprenkuSQA kujtimprenkuSQA kujtimprenkuSQA approved these changes

@DamirSQA DamirSQA Awaiting requested review from DamirSQA

@HarisSQA HarisSQA Awaiting requested review from HarisSQA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amirsaran3 @kujtimprenkuSQA