Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added InstantLinkWallet type #727

Merged
merged 13 commits into from
Mar 15, 2023
Merged

Conversation

amirsaran3
Copy link
Collaborator

@amirsaran3 amirsaran3 commented Mar 13, 2023

Description

This will enable wallet developers to run signIn function on initialization.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@amirsaran3 amirsaran3 marked this pull request as ready for review March 13, 2023 13:06
@github-actions github-actions bot changed the title Added runOnStartup metadata, added logic to run wallet signIn on startup feat: Added runOnStartup metadata, added logic to run wallet signIn on startup Mar 13, 2023
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments in-line, once the comments are addressed I think we need feedback from Ben.

I think we need to know how they handle the contractId between dApp and Keypom because in the video it was not clear and in that autoSignIn function they hard code it.

packages/core/src/lib/wallet/wallet.types.ts Outdated Show resolved Hide resolved
@amirsaran3 amirsaran3 changed the title feat: Added runOnStartup metadata, added logic to run wallet signIn on startup feat: Added InstantLinkWallet type Mar 15, 2023
@amirsaran3 amirsaran3 merged commit 07ef09a into dev Mar 15, 2023
@amirsaran3 amirsaran3 deleted the running-wallets-on-startup branch March 15, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants