-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added InstantLinkWallet type #727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Added runOnStartup metadata, added logic to run wallet signIn on startup
feat: Added runOnStartup metadata, added logic to run wallet signIn on startup
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments in-line, once the comments are addressed I think we need feedback from Ben.
I think we need to know how they handle the contractId
between dApp and Keypom because in the video it was not clear and in that autoSignIn function they hard code it.
packages/core/src/lib/services/wallet-modules/wallet-modules.service.ts
Outdated
Show resolved
Hide resolved
amirsaran3
changed the title
feat: Added runOnStartup metadata, added logic to run wallet signIn on startup
feat: Added InstantLinkWallet type
Mar 15, 2023
kujtimprenkuSQA
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will enable wallet developers to run
signIn
function on initialization.Checklist:
Type of change.