Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added custom language string for developers #728

Merged
merged 12 commits into from
Mar 22, 2023
Merged

feat: Added custom language string for developers #728

merged 12 commits into from
Mar 22, 2023

Conversation

HarisSQA
Copy link
Contributor

@HarisSQA HarisSQA commented Mar 14, 2023 •
edited by kujtimprenkuSQA
Loading

Description

  • Added optional languageCode in setupWalletSelector(params), this allows dApps to disable language detection from the browser, and only use the language provided in the languageCode.

Closes (#725)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title Added custom language string for developers feat: Added custom language string for developers Mar 14, 2023
DamirSQA
DamirSQA previously approved these changes Mar 15, 2023
View reviewed changes
@DamirSQA DamirSQA marked this pull request as draft March 15, 2023 23:16
@HarisSQA HarisSQA requested a review from DamirSQA March 17, 2023 15:09
DamirSQA
DamirSQA suggested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@DamirSQA DamirSQA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the changes are made, docs can be updated as well.

packages/core/src/lib/translate/translate.ts Outdated Show resolved Hide resolved
packages/core/src/lib/options.ts Outdated Show resolved Hide resolved
packages/core/src/lib/options.types.ts Outdated Show resolved Hide resolved
@kujtimprenkuSQA kujtimprenkuSQA marked this pull request as ready for review March 22, 2023 12:37
@DamirSQA DamirSQA self-requested a review March 22, 2023 13:35
@HarisSQA HarisSQA merged commit c22aac6 into dev Mar 22, 2023
@HarisSQA HarisSQA deleted the SQC-480 branch March 22, 2023 13:39
@kujtimprenkuSQA kujtimprenkuSQA mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kujtimprenkuSQA kujtimprenkuSQA kujtimprenkuSQA left review comments

@DamirSQA DamirSQA DamirSQA approved these changes

@amirsaran3 amirsaran3 Awaiting requested review from amirsaran3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarisSQA @kujtimprenkuSQA @DamirSQA