Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added translations for Croatian, Slovenian, Serbian, and Macedonian #734

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

alenNBH
Copy link

@alenNBH alenNBH commented Mar 20, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

…n, added logic in getLanguage method for changing language
@AmmarHumackicSQA
Copy link
Collaborator

Hi @alenNBH thanks (hvala 🙂) for the work on this!

@alenNBH
Copy link
Author

alenNBH commented Mar 21, 2023

It was a team effort :) Let me know if everything is ok.

@DamirSQA
Copy link
Collaborator

Hi @alenNBH, thanks for opening the PR, review is in progress, I'll post the comments when it is completed.

packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sl.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/mk.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/mk.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/mk.json Outdated Show resolved Hide resolved
@DamirSQA
Copy link
Collaborator

@alenNBH , is it possible to get a translation for "Export Accounts" section as well?

@alenNBH
Copy link
Author

alenNBH commented Mar 21, 2023

@alenNBH , is it possible to get a translation for "Export Accounts" section as well?

Hi @DamirSQA, we will do the translations and fixes and will come back to you as soon as we are done.

@alenNBH
Copy link
Author

alenNBH commented Mar 31, 2023

Hi, I have added translations for the Export accounts sections and have resolved open changes.
Let me know if there is anything left that needs to be fixed/resolved.

@alenNBH alenNBH requested a review from DamirSQA March 31, 2023 09:23
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/sr.json Outdated Show resolved Hide resolved
packages/core/src/lib/locale/hr.json Outdated Show resolved Hide resolved
@DamirSQA
Copy link
Collaborator

DamirSQA commented Mar 31, 2023

Hi, I have added translations for the Export accounts sections and have resolved open changes. Let me know if there is anything left that needs to be fixed/resolved.

Hi @alenNBH, thanks for adding "exportAccounts", and addressing required changes. I've added some comments, so if would be great if they could be addressed as well.

@alenNBH alenNBH requested a review from DamirSQA April 3, 2023 10:09
@DamirSQA DamirSQA merged commit 766894f into near:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants