Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix overview account list UI for Ledger #747

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix: Fix overview account list UI for Ledger #747

merged 1 commit into from
Mar 31, 2023

Conversation

kujtimprenkuSQA
Copy link
Collaborator

@kujtimprenkuSQA kujtimprenkuSQA commented Mar 31, 2023 •
edited
Loading

Description

  • Fixed the bug in the ledger in the Overview Account List view of modal-ui to immediately populate the selectedAccounts when only one account is found.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title Fix overview account list UI for Ledger fix: Fix overview account list UI for Ledger Mar 31, 2023
@kujtimprenkuSQA kujtimprenkuSQA merged commit f2a001d into dev Mar 31, 2023
@kujtimprenkuSQA kujtimprenkuSQA deleted the SQC-496/fix-modal-ui-for-ledger branch March 31, 2023 14:49
@kujtimprenkuSQA kujtimprenkuSQA mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamirSQA DamirSQA DamirSQA approved these changes

@amirsaran3 amirsaran3 Awaiting requested review from amirsaran3

@HarisSQA HarisSQA Awaiting requested review from HarisSQA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kujtimprenkuSQA @DamirSQA