Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Revert type changes in WalletSelectorContextValue interface in react example #769

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Apr 7, 2023

Description

  • Removed null type from the modal and selector in WalletSelectorContextValue to avoid using the ! everywhere in child components.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title Revert type changes in WalletSelectorContextValue interface in react example chore: Revert type changes in WalletSelectorContextValue interface in react example Apr 7, 2023
@github-actions github-actions bot changed the title chore: Revert type changes in WalletSelectorContextValue interface in react example refactor: Revert type changes in WalletSelectorContextValue interface in react example Apr 7, 2023
@kujtimprenkuSQA kujtimprenkuSQA merged commit faa3c7e into dev Apr 7, 2023
@kujtimprenkuSQA kujtimprenkuSQA deleted the revert-type-changes-in-react-example branch April 7, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants