Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor markup in modal-ui and modal-ui-js #803

Merged
merged 4 commits into from
May 5, 2023

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented May 5, 2023

Description

Work here was done on top of #801 so this PR must be merged only after the other one is approved and merged.

  • Refactored components in modal-ui and modal-ui-js and moved svg markup code into separate files/componnents.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title Refactor markup in moda-ui and modal-ui-js refactor: Refactor markup in moda-ui and modal-ui-js May 5, 2023
@kujtimprenkuSQA kujtimprenkuSQA changed the title refactor: Refactor markup in moda-ui and modal-ui-js refactor: Refactor markup in modal-ui and modal-ui-js May 5, 2023
@github-actions github-actions bot changed the title refactor: Refactor markup in modal-ui and modal-ui-js refactor: Refactor markup in moda-ui and modal-ui-js May 5, 2023
@github-actions github-actions bot changed the title refactor: Refactor markup in moda-ui and modal-ui-js refactor: Refactor markup in modal-ui and modal-ui-js May 5, 2023
@kujtimprenkuSQA kujtimprenkuSQA merged commit 2ff4d73 into dev May 5, 2023
@kujtimprenkuSQA kujtimprenkuSQA deleted the refactor-icons branch May 5, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants