Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added margin auto to gradient border #179

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

bp289
Copy link

@bp289 bp289 commented Aug 10, 2023

No description provided.

@bp289 bp289 temporarily deployed to dev August 10, 2023 15:50 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Page Speed results for http://pr-preview-bioconductor-pr179.s3-website-us-east-1.amazonaws.com using desktop


Summary

URL: pr-preview-bioconductor-pr179.s3-website-us-east-1.amazonaws.com
Strategy: desktop
Performance: 70

Field Data

The Chrome User Experience Report does not have sufficient real-world speed data for this page.

Lab Data

Cumulative Layout Shift | 0.001
First Contentful Paint | 2.7s
Largest Contentful Paint | 2.7s
Speed Index | 2.7s
Total Blocking Time | 0ms

Opportunities

No opportunities provided.


Page Speed results for http://pr-preview-bioconductor-pr179.s3-website-us-east-1.amazonaws.com using mobile


Summary

URL: pr-preview-bioconductor-pr179.s3-website-us-east-1.amazonaws.com
Strategy: mobile
Performance: 61

Field Data

The Chrome User Experience Report does not have sufficient real-world speed data for this page.

Lab Data

Cumulative Layout Shift | 0
First Contentful Paint | 6.0s
Largest Contentful Paint | 7.1s
Speed Index | 6.3s
Total Blocking Time | 20ms

Opportunities

No opportunities provided.


@github-actions
Copy link

Running axe-core 4.7.2 in chrome-headless

Copy link

@MariamM110 MariamM110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaves a few issues too, when in phone mode theres no margin I think its best to change this class to

.doodle-data-scientist-container { display: flex; justify-content: center; margin-top: 1rem; margin-bottom: 1rem; }

and add a container class to the
<div class="data-scientist-container">

@bp289 bp289 temporarily deployed to dev August 10, 2023 16:06 — with GitHub Actions Inactive
@bp289 bp289 requested a review from MariamM110 August 10, 2023 16:06
@bp289 bp289 temporarily deployed to dev August 10, 2023 16:07 — with GitHub Actions Inactive
@bp289 bp289 merged commit 2fdc52c into redesign2023 Aug 10, 2023
3 checks passed
@bp289 bp289 temporarily deployed to dev August 10, 2023 16:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants