Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed extra bullets, added ul #184

Merged
merged 6 commits into from
Aug 11, 2023
Merged

removed extra bullets, added ul #184

merged 6 commits into from
Aug 11, 2023

Conversation

bp289
Copy link

@bp289 bp289 commented Aug 10, 2023

closes #181

@bp289 bp289 temporarily deployed to dev August 10, 2023 16:21 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited
Loading

Page Speed results for http://pr-preview-bioconductor-pr184.s3-website-us-east-1.amazonaws.com using desktop

Summary

URL: pr-preview-bioconductor-pr184.s3-website-us-east-1.amazonaws.com
Strategy: desktop
Performance: 68

Field Data

The Chrome User Experience Report does not have sufficient real-world speed data for this page.

Lab Data

Cumulative Layout Shift | 0.001
First Contentful Paint | 2.7s
Largest Contentful Paint | 2.9s
Speed Index | 2.7s
Total Blocking Time | 0ms

Opportunities

No opportunities provided.

Page Speed results for http://pr-preview-bioconductor-pr184.s3-website-us-east-1.amazonaws.com using mobile

Summary

URL: pr-preview-bioconductor-pr184.s3-website-us-east-1.amazonaws.com
Strategy: mobile
Performance: 57

Field Data

The Chrome User Experience Report does not have sufficient real-world speed data for this page.

Lab Data

Cumulative Layout Shift | 0.001
First Contentful Paint | 7.1s
Largest Contentful Paint | 7.6s
Speed Index | 9.3s
Total Blocking Time | 40ms

Opportunities

No opportunities provided.

@github-actions
Copy link

Running axe-core 4.7.2 in chrome-headless

SociableSteve
SociableSteve requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@SociableSteve SociableSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an extra slash in here. \*Current Package Review Administrators - can you remove that please? Also if you can make that line have a bit more space above it - maybe put it in P tags?

@bp289 bp289 temporarily deployed to dev August 11, 2023 08:32 — with GitHub Actions Inactive
SociableSteve
SociableSteve requested changes Aug 11, 2023
View reviewed changes
lib/data_sources/bioc_views.rb Outdated Show resolved Hide resolved
scripts/get_json.rb Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@bp289 bp289 temporarily deployed to dev August 11, 2023 08:36 — with GitHub Actions Inactive
@bp289 bp289 temporarily deployed to dev August 11, 2023 08:39 — with GitHub Actions Inactive
@SociableSteve SociableSteve temporarily deployed to dev August 11, 2023 08:43 — with GitHub Actions Inactive
@SociableSteve SociableSteve temporarily deployed to dev August 11, 2023 08:44 — with GitHub Actions Inactive
@bp289 bp289 merged commit ee712ba into redesign2023 Aug 11, 2023
3 checks passed
@bp289 bp289 temporarily deployed to dev August 11, 2023 08:49 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SociableSteve SociableSteve SociableSteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

couple of double bullets on reviewers page
2 participants
@bp289 @SociableSteve