Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: once the demo app is deployed can it scale up and down when under load? #192

Merged
merged 3 commits into from
Oct 26, 2023
Merged

ci: once the demo app is deployed can it scale up and down when under load? #192

merged 3 commits into from
Oct 26, 2023

Conversation

spchortis
Copy link
Contributor

@spchortis spchortis commented Sep 6, 2023 •
edited by Pehesi97
Loading

What does this PR do?

  • Sample app integration test was updated in order to support knative scale in/out validation
  • Knative does not provide a way to speed up scale in process, this is the reason a time delay was added.

Related issues

Closes #162

Checklist before merging

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked the contributing document.
  • I have checked the existing Pull Requests to see whether someone else has raised a similar idea or question.
  • I have added tests that prove my fix is effective or that my feature works.

@Pehesi97 Pehesi97 mentioned this pull request Oct 25, 2023
Closed
@Pehesi97 Pehesi97 changed the title closes: once the demo app is deployed can it scale up and down when under load? ci: once the demo app is deployed can it scale up and down when under load? Oct 25, 2023
@Pehesi97 Pehesi97 self-requested a review October 25, 2023 14:47
@Pehesi97 Pehesi97 merged commit d0a2da5 into main Oct 26, 2023
10 checks passed
@Pehesi97 Pehesi97 deleted the chore/knative-scale branch October 26, 2023 14:45
@francardoso93 francardoso93 mentioned this pull request Nov 7, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pehesi97 Pehesi97 Pehesi97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

once the demo app is deployed can it scale up and down when under load?
2 participants
@spchortis @Pehesi97