-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official expo action for deploy previews when published #1006
Comments
It's released :) |
The generated QR code seems invalid: If I decode the old QR codes and the new one, there are some differences:
I tested it with my iPhone with Expo Go installed. I will park this for now, since I didn't find any solution. |
@davideroffo can you please post a comment on the original issue/PR in the expo repo pointing to this PR and giving them enough information to figure out what's going on? |
Commented on the original issue: expo/expo-github-action#189 (comment) |
@AlanSl I think this is still blocked but please double check |
@simoneb I figured it out :) https://github.com/expo/expo-github-action/tree/main/preview#whats-inside by default it is building for I will be submitting a PR soon, because expo-go only supports apps with expo >= 49 and we currently are at 47 |
I'm afraid that upgrading expo sdk is not an option for us though, too complicated |
@simoneb do you want me to investigate? spend 30m - 1h or give up already? |
not worth it, we tried multiple times, too many breaking changes |
@simoneb then we should close this issue, because the fix was using the right qr-code build target, but expo-go cannot work with the current expo version |
Fine then 👌 |
Currently we're using a custom approach built in a workflow. When the official support is released, we should switch to that one
expo/expo-github-action#206
The text was updated successfully, but these errors were encountered: