Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official expo action for deploy previews when published #1006

Closed
simoneb opened this issue Feb 20, 2023 · 11 comments · May be fixed by #1012
Closed

Use official expo action for deploy previews when published #1006

simoneb opened this issue Feb 20, 2023 · 11 comments · May be fixed by #1012

Comments

@simoneb
Copy link
Member

simoneb commented Feb 20, 2023

Currently we're using a custom approach built in a workflow. When the official support is released, we should switch to that one

expo/expo-github-action#206

@byCedric
Copy link

It's released :)

@davideroffo
Copy link
Contributor

The generated QR code seems invalid: QR code detected no usable data found.

If I decode the old QR codes and the new one, there are some differences:

  • old QR code, parsed result: exp://u.expo.dev/update/822fb168-daeb-4012-b2ca-ed78669d52c5
  • new QR code, parsed result: exp+optic-expo://expo-development-client/?url=https://u.expo.dev/e3c6e759-c8c5-41a8-861e-b3e4adab619a/group/ac6df604-a218-4604-a830-d21509ce9cb6

I tested it with my iPhone with Expo Go installed.

I will park this for now, since I didn't find any solution.

@davideroffo davideroffo removed their assignment Feb 21, 2023
@simoneb
Copy link
Member Author

simoneb commented Feb 21, 2023

@davideroffo can you please post a comment on the original issue/PR in the expo repo pointing to this PR and giving them enough information to figure out what's going on?

@davideroffo
Copy link
Contributor

Commented on the original issue: expo/expo-github-action#189 (comment)

@simoneb
Copy link
Member Author

simoneb commented Apr 19, 2023

@AlanSl I think this is still blocked but please double check

@puskin94
Copy link

@AlanSl I think this is still blocked but please double check

@simoneb I figured it out :)

https://github.com/expo/expo-github-action/tree/main/preview#whats-inside

by default it is building for dev-build which cannot be loaded from expo-go . Changing the qr-target to expo-go fixed the issue!

I will be submitting a PR soon, because expo-go only supports apps with expo >= 49 and we currently are at 47

@simoneb
Copy link
Member Author

simoneb commented Apr 23, 2024

I'm afraid that upgrading expo sdk is not an option for us though, too complicated

@puskin94
Copy link

I'm afraid that upgrading expo sdk is not an option for us though, too complicated

@simoneb do you want me to investigate? spend 30m - 1h or give up already?

@simoneb
Copy link
Member Author

simoneb commented Apr 23, 2024

not worth it, we tried multiple times, too many breaking changes

@puskin94
Copy link

@simoneb then we should close this issue, because the fix was using the right qr-code build target, but expo-go cannot work with the current expo version

@simoneb
Copy link
Member Author

simoneb commented Apr 23, 2024

Fine then 👌

@simoneb simoneb closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants