Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(preview): add eas update preview sub-action #206

Merged
merged 12 commits into from
Feb 20, 2023

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Feb 16, 2023

Linked issue

Fixes #189

Add a new sub-action that eventually replaces the preview-comment subaction, and adds support for EAS Update.

Additional context

This is still pending a required change in the Expo website, hold off on merging and releasing.

@byCedric byCedric force-pushed the feature/preview-eas-support branch 3 times, most recently from 57992c2 to 9c25434 Compare February 18, 2023 16:00
@byCedric byCedric force-pushed the feature/preview-eas-support branch 6 times, most recently from 9d6631d to 7902fca Compare February 18, 2023 16:20
@expo expo deleted a comment from github-actions bot Feb 18, 2023
@expo expo deleted a comment from github-actions bot Feb 18, 2023
@github-actions
Copy link

github-actions bot commented Feb 18, 2023

🚀 Expo preview is ready!

  • Project → test-preview
  • Platforms → android, ios
  • Scheme → expogithubaction, ega
  • Runtime Version → exposdk:51.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@github-actions
Copy link

github-actions bot commented Feb 18, 2023

🚀 Expo preview is ready!

  • Project → test-preview
  • Platforms → android, ios
  • Scheme → expogithubaction
Android
(exposdk:51.0.0)
More info
iOS
(1.0.0)
More info

Learn more about 𝝠 Expo Github Action

IvanGodinez21 added a commit to BrightCoders-Institute/BCDIC22-RN-proyecto-final-team3 that referenced this pull request Feb 19, 2023
Notes:
- Replaced `expo` command with `eas`
- Removed comment preview until the next update (v8), check:
  - expo/expo-github-action#206
  - expo/expo-github-action#207
  - expo/expo-github-action#208
@byCedric
Copy link
Member Author

@IvanGodinez21 The release is scheduled for Monday, probably around 18:00 CET, in case that helps you schedule things :) (I saw your commit, mentioning v8)

@IvanGodinez21
Copy link

@IvanGodinez21 The release is scheduled for Monday, probably around 18:00 CET, in case that helps you schedule things :) (I saw your commit, mentioning v8)

Thanks for the info, I'll be waiting 🤩

@byCedric byCedric marked this pull request as ready for review February 20, 2023 14:08
@byCedric byCedric merged commit f4d6037 into main Feb 20, 2023
github-actions bot pushed a commit that referenced this pull request Feb 20, 2023
## [8.0.0](7.2.1...8.0.0) (2023-02-20)

### ⚠ BREAKING CHANGES

* **preview-comment:** add deprecation notice with blog post (#207)

### New features

* **preview:** add eas update preview sub-action ([#206](#206)) ([f4d6037](f4d6037))

### Code changes

* **preview-comment:** add deprecation notice with blog post ([#207](#207)) ([d2b3e6c](d2b3e6c))

### Other chores

* bump http-cache-semantics from 4.1.0 to 4.1.1 ([#205](#205)) ([b1a8c06](b1a8c06))

### Documentation changes

* **preview-comment:** emphasize that this sub-action is now deprecated ([f4af238](f4af238))
* update examples for v8 ([#210](#210)) ([3d1cf9a](3d1cf9a))
* update the readme with new examples ([#208](#208)) ([ae5d1a1](ae5d1a1))
@github-actions
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EAS Update: Preview with comment
2 participants