Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt exported tokens file #591

Closed
3 tasks done
davideroffo opened this issue Jul 12, 2022 · 0 comments · Fixed by #688
Closed
3 tasks done

Encrypt exported tokens file #591

davideroffo opened this issue Jul 12, 2022 · 0 comments · Fixed by #688
Assignees

Comments

@davideroffo
Copy link
Contributor

davideroffo commented Jul 12, 2022

With this PR #590 the export and import feature has been added to the application.

Currently, we are storing a plain text file with the file content (information about secrets) easily readable and importable from any user.

We want to store the exported file with encryption, where the secret should be a concatenation of [secret_string].[user_id]
In this way, the file is no longer readable and can be imported only by the user (user_id) who created (exported) that file.

Things to do:

  • while exporting encrypt the file-content with [secret_string].[user_id] secret
  • update the import method in order to decrypt first the file-content the user is trying to import
  • in order to be backward compatible, if a file is in plain text import it anyway for now (@simoneb is this ok?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants