Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the encryption to file exporting #688

Merged
merged 11 commits into from
Sep 19, 2022
Merged

Added the encryption to file exporting #688

merged 11 commits into from
Sep 19, 2022

Conversation

SirCQQ
Copy link
Contributor

@SirCQQ SirCQQ commented Sep 14, 2022 •
edited
Loading

Added the encryption to file exporting but kept plain text import still available for backward compatibility.
Linked Issue #591

@SirCQQ SirCQQ requested review from simoneb and confraria and removed request for simoneb September 14, 2022 20:30
@SirCQQ SirCQQ linked an issue Sep 14, 2022 that may be closed by this pull request
Encrypt exported tokens file #591
Closed
3 tasks
simoneb
simoneb requested changes Sep 15, 2022
View reviewed changes
app.config.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/lib/importExport.ts Outdated Show resolved Hide resolved
simoneb
simoneb reviewed Sep 15, 2022
View reviewed changes
src/lib/importExport.ts Outdated Show resolved Hide resolved
@SirCQQ SirCQQ requested a review from simoneb September 16, 2022 07:53
@confraria
Copy link
Contributor

tested export encrypted ✅ (confirmed the file is encrypted in adb cli)
tested import encrypted ✅
tested import plain text ✅
tested import plain text with a different uid ✅

simoneb
simoneb requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, plus, there are no tests for the feature. Please add tests

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/lib/importExport.ts Outdated Show resolved Hide resolved
src/lib/importExport.ts Outdated Show resolved Hide resolved
src/lib/importExport.ts Outdated Show resolved Hide resolved
src/lib/importExport.ts Outdated Show resolved Hide resolved
src/screens/ImportFileSecret.tsx Outdated Show resolved Hide resolved
@simoneb
Copy link
Member

simoneb commented Sep 19, 2022

@SirCQQ where do we stand with this PR?

@SirCQQ
Copy link
Contributor Author

SirCQQ commented Sep 19, 2022

@simoneb I forgot to push the changes for the comments and the tests on Friday, can you check if those are good?

simoneb
simoneb reviewed Sep 19, 2022
View reviewed changes
app.json Outdated Show resolved Hide resolved
@SirCQQ SirCQQ requested a review from simoneb September 19, 2022 09:34
@SirCQQ SirCQQ merged commit 670e391 into master Sep 19, 2022
@SirCQQ SirCQQ deleted the file-encryption branch September 19, 2022 10:02
This was referenced Sep 20, 2022
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

@confraria confraria Awaiting requested review from confraria

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encrypt exported tokens file
3 participants
@SirCQQ @confraria @simoneb