Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send package info when requesting OTP #1198

Merged
merged 6 commits into from
Jun 6, 2023

Conversation

guilhermelimak
Copy link
Contributor

@guilhermelimak guilhermelimak commented May 31, 2023

This PR adds support for displaying package information (name and version) when receiving an OTP notification both when the
user clicks on the notification and on the notifications list.

image

image

Reference #1186.

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@guilhermelimak guilhermelimak changed the title chore: remove --dev-client from yarn start command feat: send package info when requesting OTP May 31, 2023
@github-actions
Copy link

github-actions bot commented May 31, 2023

Preview available at https://expo.dev/accounts/nearform/projects/optic-expo/updates/d188ad30-e28f-4a3c-82e4-9735769f5c82

Or scan QR Codes...

android:
QR Code

ios:
QR Code}

@guilhermelimak guilhermelimak marked this pull request as ready for review June 1, 2023 21:55
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Show resolved Hide resolved
src/Main.tsx Show resolved Hide resolved
@guilhermelimak guilhermelimak merged commit 344b7c8 into master Jun 6, 2023
@guilhermelimak guilhermelimak deleted the feat/add-payload-to-notifications branch June 6, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants