Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document release certificate generation process #1279

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

williamlines
Copy link
Contributor

Documenting the process for creating new certificates for releases to the iOS App Store.

closes: #1278

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Preview available at https://expo.dev/accounts/nearform/projects/optic-expo/updates/911e60a9-b39f-4aa4-a377-200dbef7d4ae

Or scan QR Codes...

android:
QR Code

ios:
QR Code}

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, just making sure we're not disclosing sensitive information in the screenshots especially, right? This repo is public.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also one Q: why would the certificate expire in the first place? Is there a way to prevent that from happening?

@williamlines
Copy link
Contributor Author

@simoneb The max duration you can specify for a certificate is one year, unfortunately. So this will need to be an ongoing consideration

@williamlines
Copy link
Contributor Author

All good for me, just making sure we're not disclosing sensitive information in the screenshots especially, right? This repo is public.

I think this is safe but I will double check with Manos

@williamlines
Copy link
Contributor Author

The screenshot is safe to share

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @williamlines and @manosim for looking into it

@williamlines williamlines merged commit 72c9812 into master Sep 27, 2023
6 checks passed
@williamlines williamlines deleted the docs/ios-release-certs branch September 27, 2023 08:01
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a system to update Apple certs
2 participants