feat: enhance OTP request flow in the app #222
Conversation
|
App is ready for review, you can see it here. |
|
App is ready for review, you can see it here. |
1 similar comment
|
App is ready for review, you can see it here. |
|
App is ready for review, you can see it here. |
|
App is ready for review, you can see it here. |
…nd remove global useFakeTimers
|
App is ready for review, you can see it here. |
|
|
||
| const filteredTokens = useMemo(() => { | ||
| if (search.length > 1) { | ||
| return tokens.filter(({ description }) => |
There was a problem hiding this comment.
If the filter result is zero, could we filter by token?
For example: I see a token on my CI, and I want to check that the description match because I don't remember if I have copied&pasted it from another setup
There was a problem hiding this comment.
I've created a separate issue for this. See here: #262
|
App is ready for review, you can see it here. |
src/screens/CreateTokenScreen.tsx
Outdated
| } | ||
|
|
||
| return ( | ||
| <View style={styles.container}> |
There was a problem hiding this comment.
nitpick: The keyboard does not hide when tapping anywhere in the screen other than buttons. Wouldn't say it's too important.
|
App is ready for review, you can see it here. |
This PR implements the new flows described in https://www.figma.com/file/xsPf6IIM9AevLN5gZlXM4q/Optic-(Copy
The primary additions to the app are as follows:
The list of new screens are as follows:
This PR also includes an update of the react native testing library as well as a fix to make tests start more quickly (by not including
useFakeTimersin the jest setup file. This upgrade allows tests tests to be async. Previously tests would timeout if this was attempted.To trigger the OTP flow call the following endpoint:
https://optic-zf3votdk5a-ew.a.run.app/api/generate/<token>Below are screenshots of the new flow taken on a real device:
)