chore: Upgrade to Node 16 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
reviewed
Nov 25, 2021
README.md
Outdated
Comment on lines
22
to
24
|
|
||
| Optic uses the current LTS version of Node |
There was a problem hiding this comment.
let's move this to the top, it's one of the first things that somebody who needs to run the app locally will need to know. Let's create a Requirements heading and list this and yarn as requirements
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| 14.17.1 | |||
| v16.11.0 | |||
There was a problem hiding this comment.
can we use generically "16"? we don't really care about minor/patch, as long as it's 16
allforabit
approved these changes
Nov 25, 2021
|
App is ready for review, you can see it here. |
simoneb
approved these changes
Nov 25, 2021
|
App is ready for review, you can see it here. |
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250