Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: biometric auth #297

Merged
merged 5 commits into from
Dec 23, 2021
Merged

feat: biometric auth #297

merged 5 commits into from
Dec 23, 2021

Conversation

salmanm
Copy link
Contributor

@salmanm salmanm commented Dec 22, 2021 •
edited
Loading

Closes #295

@github-actions
Copy link

App is ready for review, you can see it here.

@salmanm salmanm mentioned this pull request Dec 23, 2021
Closed
@github-actions
Copy link

App is ready for review, you can see it here.

simoneb
simoneb approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! There's a small UI glitch in the settings page, the setting name and the toggle are not vertically aligned. Once that's fixed this is good to go

@salmanm salmanm enabled auto-merge (squash) December 23, 2021 10:47
@salmanm salmanm merged commit 570165a into master Dec 23, 2021
@salmanm salmanm deleted the biometric-auth branch December 23, 2021 10:49
@github-actions
Copy link

App is ready for review, you can see it here.

This was referenced Sep 20, 2022
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use biometric authentication to approve requests
2 participants
@salmanm @simoneb