Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display email address #324

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Display email address #324

merged 2 commits into from
Jan 11, 2022

Conversation

estherixz
Copy link
Contributor

@estherixz estherixz commented Jan 7, 2022

Add email and logout button in the settings screen
Linked issue #322

Email and logout button in the settings screen
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

App is ready for review, you can see it here.

@radomird radomird self-requested a review January 10, 2022 15:54
Copy link
Contributor

@radomird radomird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, except one minor visual thing. The text color on the back button on top < Your tokens on iOS is very simila to the background color so it's really hard to see.

Here is a screenshot, for reference:

IMG_1011

Copy link
Contributor

@salmanm salmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great. LGTM (apart from the iOS issue Radomir reported)

@@ -17,15 +18,19 @@ const styles = StyleSheet.create({
},
scrollView: {
flexGrow: 1,
justifyContent: 'space-between',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

App is ready for review, you can see it here.

@radomird radomird self-requested a review January 11, 2022 10:35
Copy link
Contributor

@radomird radomird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and consistent now 👍

@estherixz estherixz merged commit b8a6880 into master Jan 11, 2022
@estherixz estherixz deleted the feat/display-user-email branch January 11, 2022 11:24
@estherixz estherixz linked an issue Jan 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show logged user
3 participants