-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat | generate token for secret #42
Conversation
1f4e0f7
to
4984cb4
Compare
4984cb4
to
30f101a
Compare
30f101a
to
f06fff2
Compare
@simoneb I guess I'm leaving this here for now. The code is functional and does the job of talking to the server to get a token. It works fine. There are a couple of things missing though. Lines 107 to 155 in f06fff2
This unit test is for instance passing but not without logging an error to the console. I spent some time with it trying to figure out what was going on but at this point I think we should consider breaking it down into smaller tests. This one is already doing too much imho. We're also missing writing new unit tests at least for the new class being added here. |
* fix: remove unused imports * feat: add back-end api wrapper * feat: ask server for a token * feat: improve home page ui Co-authored-by: Dylson Valente Neto <[email protected]>
#80 included commits from this PR, so closing... |
Closes: #5
This PR adds:
<Secret />
component with a button to trigger the token generation.