fix: opening updates in expo go in android #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoneb
approved these changes
Sep 22, 2022
|
solved the previous error, but we get a new one. |
confraria
force-pushed
the
fix-expo-go-updates
branch
from
27a2863
to
06d927e
Compare
|
@simoneb could you try the pr-722 update int he expo go app? 🙆♂️ |
confraria
commented
Sep 26, 2022
| function isExpoHosted() { | ||
| const hostUri = getHostUri(); | ||
| return !!(hostUri && | ||
| (/^(.*\.)?(expo\.io|exp\.host|exp\.direct|expo\.test|expo\.dev)(:.*)?(\/.*)?$/.test(hostUri) || |
There was a problem hiding this comment.
|expo\.dev was missing from this regex
🙃 @keith-kurak gave me the tip!
simoneb
approved these changes
Sep 26, 2022
|
does expo have an open issue about this? can we contribute this back to them perhaps? in any case, let's track an issue in this repo to remind ourselves to undo this workaround |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #719