chore: upgrade expo and restructure app #82
Conversation
| @@ -14,41 +14,42 @@ | |||
| "dependencies": { | |||
| "@expo-google-fonts/didact-gothic": "^0.1.0", | |||
| "@expo-google-fonts/poppins": "^0.1.0", | |||
| "@react-native-async-storage/async-storage": "1.15.1", | |||
| "@react-native-async-storage/async-storage": "^1.13.0", | |||
There was a problem hiding this comment.
expo cli did this downgrade
| "expo-secure-store": "~10.1.0", | ||
| "expo-status-bar": "~1.0.4", | ||
| "expo-web-browser": "~9.1.0", | ||
| "firebase": "8.2.3", |
There was a problem hiding this comment.
We had 8.4.1 (before I made it 7.9.0) and expo upgrade util automatically made it 8.2.3 so I kept it to avoid firebase warning.
| "react-native-web": "~0.13.12", | ||
| "url-otpauth": "^2.0.0", | ||
| "uuid": "8.3.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "~7.13.15", | ||
| "@babel/core": "~7.9.0", |
There was a problem hiding this comment.
Same, expo upgrade util downgraded it. We could up it back, but may be it downgraded for some reason!?
There was a problem hiding this comment.
The package versions are fine, in general it's good to stick to whatever expo wants. firebase was an exception really because at some point the version that expo wanted didn't work.
I'm not sure about the whole app restructuring, unless it comes from expo itself. If not, unless you have a good reason to change the app structure I would consider keeping it the same for the sake of remaining consistent with the expo template, possibly making further upgrades easier because there may be some assumptions that expo makes about the file system layout or contents of certain files.
| "backgroundColor": "#FFFFFF" | ||
| } | ||
| }, | ||
| "web": { | ||
| "favicon": "./assets/favicon.png" | ||
| "favicon": "./src/assets/favicon.png" |
There was a problem hiding this comment.
are the changes in this file stuff that the expo upgrade did?
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "main": "node_modules/expo/AppEntry.js", | |||
| "main": "./src/index.js", | |||
There was a problem hiding this comment.
No, I wanted to keep all the app related files under /src and other stuff outside. So had to do this.
Yes, and when deviating from that, their docs say to use
Well, I'm new in RN so no strong opinions here. But to me it makes sense to keep the bootstrapping files separate from the app code. So when upgrading expo, if the root directory has more files in it, they don't clutter the app code structutre. I mean, we had |
Fixes #81