Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display otp notifications with sound when app is already open #839

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

guilhermelimak
Copy link
Contributor

Closes #828.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure this will work fully because I would have expected to find a different configuration for the app when it's in the foreground and when it's in the background, or iow, even though they were false, both the sound and the badge (whatever it is) I believe were played with the app in the background, but not in the foreground. Anyway, this doesn't look like it'll do any damage so let's merge it and see what happens I guess

@guilhermelimak
Copy link
Contributor Author

Not entirely sure this will work fully because I would have expected to find a different configuration for the app when it's in the foreground and when it's in the background, or iow, even though they were false, both the sound and the badge (whatever it is) I believe were played with the app in the background, but not in the foreground. Anyway, this doesn't look like it'll do any damage so let's merge it and see what happens I guess

From the docs it seems like the notification handler is only used when the app is running. I also tested a couple of times to make sure it worked so I'm pretty confident.

@guilhermelimak guilhermelimak merged commit fc2b6f2 into master Nov 16, 2022
@guilhermelimak guilhermelimak deleted the feat/show-notifications-with-app-open branch November 16, 2022 16:14
@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a request arrives when the app is open, no notification happens
2 participants