fix: show add secret button only on home screen
#841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok so the build error is caused by #844. we probably need to do some wrapping in quotes or something |
simoneb
approved these changes
Nov 16, 2022
guilhermelimak
changed the title
add secret button only on home screen
Remove portal wrapping `Add secret` FAB. Update test snapshots.
guilhermelimak
force-pushed
the
feat/show-add-secret-only-on-homepage
branch
from
1a42369
to
cab24bf
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
portalwrapping theFAB.Groupcomponent so it's rendered at the page where it's being used but according to the react-native-paper docs it could cause z-index issues. I did try a couple of different scenarios (long list of secrets scrolling under the button, trying to use the buttons and dropdowns while close to the FAB) and it all seemed to work fine.If that's not an acceptable solution I can try to investigate deeper since the logic to show/hide it seems correct (it uses react-navigation's isFocused hook to check whether a page is focused and shows the button only if the homepage is focused).
Closes #831.