Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#33: Fix trigger if table contains column with non-equality type for ignore_unchanged_values=false #34

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

dzolo
Copy link
Contributor

@dzolo dzolo commented May 11, 2022

Fixes #33

@simoneb simoneb requested a review from paolochiodi May 13, 2022 08:11
@simoneb
Copy link
Member

simoneb commented May 13, 2022

@paolochiodi can you take a look at this when you have a chance?

@wshart
Copy link

wshart commented Jul 21, 2023

@paolochiodi Is there any chance this could be merged soon? I have a use-case for which the original issue would make this package a non-starter

@simoneb
Copy link
Member

simoneb commented Jul 24, 2023

@dzolo thanks for your PR and apologies for the lack of feedback. Is there a chance you can try resolving the merge conflicts in your branch? If you don't have capacity, I can try to do that instead.

@dzolo
Copy link
Contributor Author

dzolo commented Jul 25, 2023

@simoneb I have merged it.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you 🚀

@simoneb simoneb merged commit 21cd9ca into nearform:master Jul 25, 2023
6 checks passed
@wshart
Copy link

wshart commented Jul 25, 2023

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger not working if table contains column with non-equality type
3 participants