-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nebari typer cli changes #150
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @asmijafar20 it looks in pretty good shape. I added some comments and suggestions here and there.
I assume the GCP, Azure and DO docs will be updated as well.
I added the suggested changes but didn't change the screenshots specifically for each cloud provider. I will do that once we have the final structure of the CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @asmijafar20 for all your work on the CLI and docs :)
@pavithraes I believe this is ready to merge! Thanks for the thorough review as always :)
Thank you for the updates! I've added back some |
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
Co-authored-by: Pavithra Eswaramoorthy <[email protected]>
@pavithraes sorry for the untidy merge conflict clean up 😅 I think this is ready to be merged now 🙌 |
Thank you! I agree that we can merge. :) I see a couple of things to update at a later date, and I've noted them in #188:
|
Reference Issues or PRs
What does this implement/fix?
Put an
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?