Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gcloud instructions in how to deploy to GCP page #500

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

nebari-dev/nebari#2019

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 2d4e23d
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/673520634b08910008e1d1b1
😎 Deploy Preview https://deploy-preview-500--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/docs/how-tos/nebari-gcp.md Outdated Show resolved Hide resolved
@viniciusdc
Copy link
Contributor

viniciusdc commented Oct 29, 2024

this looks good to me, since you are just removing the old references for setting up Gcloud.

@marcelovilla
Copy link
Member Author

@dcmcand @viniciusdc can you take a look again and see if the requested changes have been addressed? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📬
Development

Successfully merging this pull request may close these issues.

3 participants