tell systemd to not kill child jupyterhub processes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2022 19:06
This reverts commit e1cc548.
|
Hm I tried out this change (testing #105 as well, which works!) and unfortunately it still killed a server I had running before the deploy. |
|
This has been tested an works! |
ericdwang
added a commit
to ericdwang/qhub-hpc
that referenced
this pull request
Apr 11, 2022
Follow-up to nebari-dev#106 and fixes nebari-dev#104 (again) We discovered in the JupyterHub logs that it was trying to contact the master node for jobs scheduled on worker nodes which was incorrect and led to them getting killed: ``` Notebook server job 157 started at hpc-worker-02:52649 (JupyterHub restart) server never showed up at http://hpc-master-node:52649 ``` This fixes the problem by preserving `self.server.ip` similar to `self.server.port` in `QHubHPCSpawnerBase.poll()`.
costrouc
pushed a commit
that referenced
this pull request
Apr 11, 2022
Follow-up to #106 and fixes #104 (again) We discovered in the JupyterHub logs that it was trying to contact the master node for jobs scheduled on worker nodes which was incorrect and led to them getting killed: ``` Notebook server job 157 started at hpc-worker-02:52649 (JupyterHub restart) server never showed up at http://hpc-master-node:52649 ``` This fixes the problem by preserving `self.server.ip` similar to `self.server.port` in `QHubHPCSpawnerBase.poll()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104
@costrouc I believe it's ready to merge after review.